Yesterday I gave this pet 5 moon charms and an umbrella charm but this morning it didn’t get any aspect of moon. Is this a bug?

That's odd. I'll keep an eye on this one—I looked in the database and the pet indeed has no affinity to moon (or, in fact, affinity to any aspect) but I don't see an obvious reason why the pet wouldn't have gained affinity.